Ryan Zimmerman comments

Results 239 comments of


Ryan Zimmerman

Update dependency eslint to ~8.57.0

See comments in https://github.com/RyanZim/eslint-config-problems/pull/32

.walk includes root directory, regardless of filter

@jprichardson Is this expected behavior?

.walk includes root directory, regardless of filter

SGTM, PR welcome.

use ?? and fs.promises

> readFile and readFileSync didn't exactly do the same thing. awaiting the readFile should have been inside of the try catch block and respect the throws options. (reading a file...

use ?? and fs.promises

Also, please rebase, update GitHub Actions and CircleCI configs to test on the correct versions, and add `engines`.

use ?? and fs.promises

@zardoy I don't know TypeScript, so it isn't really an option, since I have to be able to maintain the codebase. Sorry, GitHub Actions and AppVeyor config, not CircleCI :man_facepalming:

use ?? and fs.promises

AppVeyor is a working integration, however, it only does Windows, so we're using GitHub Actions for Linux testing (we used to use TravisCI here, but I just migrated over to...

Copying a Link from One File to Another Link to the Same File errors out in `isSrcSubdir`

Yeah, that's a bug. Out of curiosity, how does Node's experimental `fs.cp` behave here?

Copying a Link from One File to Another Link to the Same File errors out in `isSrcSubdir`

Yeah, `fs.cp` is based on `fse.copy`, so apparently this bug is both places. Should be raised as an issue on Node as well, so we can both fix it. Just...