rongtong

Results 72 comments of rongtong

@Stevenzall This is a good issue, How to solve the unnecessary handover jitter under the asymmetric network partition. In the current implementation, the broker role will be changed immediately if...

@hzh0425 I have created a temporary [feature/controler-broker-identify](https://github.com/apache/rocketmq/tree/feature/controler-broker-identify) branch to solve this issue. You can solve the code conflict first

> 2\. property Hi @dongeforever , There is already a property similar to controllerBrokerId in org.apache.rocketmq.controller.impl.manager.BrokerInfo#brokerIdTable The controllerBrokerId is currently allocated according to the IP. If the IP changes, there...

refer #https://github.com/apache/rocketmq/wiki/RIP-27-Auto-batching-in-producer

Tests in error: TraceDataEncoderTest.testSubAfterTraceDataFormatTest:204 » NullPointer

> @RongtongJin The truncation may also need to be done when the broker role changes. Yes, when the broker role changes, commit log and consume queue have been truncated, but...

Hi @sunxiaojian You can add a public method to get the AssignedMessageQueue.

Good catch! I think we'd better correct consumerOffset while truncating the commitlog. @fujian-zfj Could you submit a pull request to fix the issue?

In version 4.x, after the topic is deleted, the metadata of consumer offset will not be deleted, which may be why the offset is negative.

@fujian-zfj Good catch! Only PUT_ OK is write success when we put CK or ACK into the store in pop mode.