[ISSUE #4612] fix trace not complete
Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [x] Run
mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
Tests in error: TraceDataEncoderTest.testSubAfterTraceDataFormatTest:204 » NullPointer
Codecov Report
Merging #4613 (0bc153f) into develop (225bc42) will increase coverage by
0.04%. The diff coverage is85.18%.
@@ Coverage Diff @@
## develop #4613 +/- ##
=============================================
+ Coverage 43.42% 43.47% +0.04%
- Complexity 6213 6217 +4
=============================================
Files 817 817
Lines 57654 57667 +13
Branches 7873 7874 +1
=============================================
+ Hits 25037 25068 +31
+ Misses 29384 29358 -26
- Partials 3233 3241 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...nt/impl/consumer/ConsumeMessageOrderlyService.java | 50.00% <0.00%> (-0.18%) |
:arrow_down: |
| ...consumer/ConsumeMessagePopConcurrentlyService.java | 5.67% <0.00%> (-0.03%) |
:arrow_down: |
| ...lient/impl/consumer/DefaultMQPullConsumerImpl.java | 29.32% <0.00%> (-0.09%) |
:arrow_down: |
| ...apache/rocketmq/client/trace/TraceDataEncoder.java | 69.28% <75.00%> (-0.46%) |
:arrow_down: |
| ...he/rocketmq/client/hook/ConsumeMessageContext.java | 89.28% <100.00%> (+1.28%) |
:arrow_up: |
| ...pl/consumer/ConsumeMessageConcurrentlyService.java | 48.38% <100.00%> (+0.23%) |
:arrow_up: |
| ...ent/impl/consumer/DefaultLitePullConsumerImpl.java | 68.18% <100.00%> (-0.12%) |
:arrow_down: |
| ...org/apache/rocketmq/client/trace/TraceContext.java | 76.47% <100.00%> (+1.47%) |
:arrow_up: |
| ...client/trace/hook/ConsumeMessageTraceHookImpl.java | 78.57% <100.00%> (+0.38%) |
:arrow_up: |
| ...va/org/apache/rocketmq/store/FlushDiskWatcher.java | 81.25% <0.00%> (-9.38%) |
:arrow_down: |
| ... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 00da3e7...0bc153f. Read the comment docs.