Ron Lavi

Results 20 comments of Ron Lavi

@nofaralfasi looks like there is another error, @stejskalleos is working on the fix in #563

@nofaralfasi can you rebase please?

Hey @kamils-iRonin, I guess this PR fell through the cracks, I rebased it for you and fixed the conflict with the [safemode UI setting change](https://github.com/theforeman/foreman/blame/627118e65fa0cd67628696a748fbb72498afff74/app/helpers/application_helper.rb#L399)

As per the discussion in https://github.com/theforeman/foreman-js/pull/404#issuecomment-1246832103 We are not prepared yet to upgrade foreman to npm 8, let's continue the discussion at https://community.theforeman.org/t/javascript-infrastructure-update-plan/28614

@theforeman/packaging can you take a look please?

@nofaralfasi I am having a real difficulty to solve those tests that are failing.. I invested quite some time on trying to fix the tests with no success, I think...

for visibility, not sure I will have much time to continue work on this PR soon, in case you want to continue from here.. cc @nofaralfasi @stejskalleos @girijaasoni