foreman_ansible
foreman_ansible copied to clipboard
Update REX and foreman-tasks dependencies
Update foreman_remote_execution and foreman-tasks dependencies using ~>
instead of >=
.
Are we expecting some breaking changes in upcoming releases of rex or tasks?
Are we expecting some breaking changes in upcoming releases of rex or tasks?
Not that I know of.
@nofaralfasi @adamruzicka tests are failing again on:
ActiveRecord::AssociationTypeMismatch: RemoteExecutionFeature(#72560) expected, got nil which is an instance of NilClass(#40)
in #554 updating the versions and using >=
seemed to solve it, any other thoughts on why it happens?
I'm failing to reproduce that locally, not sure where it comes from. Only thing I can say is that apparently at the time when the test is run, the feature is not seeded (yet?)
@nofaralfasi can you try adding the
db:seed
step in the test setup? https://github.com/theforeman/foreman_ansible/blob/master/.github/workflows/ruby_tests.yml#L73
Do we need the db:test:prepare
?
From what I checked, db:prepare
suppose to do all three - db:create, db:migrate, and db:seed.
So should I add db:seed
instead the db:test:prepare
?
Do we need the
db:test:prepare
? From what I checked,db:prepare
suppose to do all three - db:create, db:migrate, and db:seed. So should I adddb:seed
instead thedb:test:prepare
?
Let's try and see if it fixes the tests then :)
@nofaralfasi looks like there is another error, @stejskalleos is working on the fix in #563
The issue with ActiveRecord::AssociationTypeMismatch: RemoteExecutionFeature
is also reproducible locally on master
branch, you have to destroy db, recreate it, migrate it and then you will see the error too.
But only once, for second run of bundle exec rake test:foreman_ansible -v --trace
you won't see it again.
@nofaralfasi can you rebase please?