Fixes #35088 - Remove GCE Compute resource code

[stejskalleos]

:warning: WIP, For Foreman 3.5

All code related to GCE compute resource is now in Foreman Google plugin

Related ForemanGoogle PRs

• https://github.com/stejskalleos/foreman_google/pull/48
• https://github.com/stejskalleos/foreman_google/pull/38
• https://github.com/stejskalleos/foreman_google/pull/49

[theforeman-bot]

Issues: #35088

[adamruzicka]

@stejskalleos what should we do with this?

[stejskalleos]

@adamruzicka this was planned for 3.5, but was postponed to the 3.6

[stejskalleos]

@adamruzicka Plans changed and we are going to do it in 3.5. Rebased & updated

[stejskalleos]

@ofedoren Adam is on PTO, could you please do the review and check if it's ready for merge? @ehelms could check if everything is ok with packaging?

[stejskalleos]

Updated together with https://github.com/theforeman/foreman_google/pull/54

[Ron-Lavi]

@theforeman/packaging can you take a look please?

[ekohl]

So what is the expected migration path for a user? I opened https://github.com/theforeman/foreman-packaging/pull/8666 to ensure the plugin replaces the core package, but a similar change is needed for the Debian side.

[stejskalleos]

I'll take care of the deb PR

So what is the expected migration path for a user?

When upgrading to new version, users who use GCE would have to run foreman-installer with --enable-foreman-googleoption

[adamruzicka]

I'll take care of the deb PR

So what is the expected migration path for a user?

When upgrading to new version, users who use GCE would have to run foreman-installer with --enable-foreman-googleoption

I know I'm sidetracking a bit, but could we do some installer/puppet module magic so it gets enabled automatically on upgrade, but has to be enabled explicitly on new installations to ease the upgrade?

[ekohl]

I know I'm sidetracking a bit, but could we do some installer/puppet module magic so it gets enabled automatically on upgrade, but has to be enabled explicitly on new installations to ease the upgrade?

IMHO that's very relevant. First of all, packaging side I'm trying to make sure the foreman_google package replaces the foreman-gce package. That means a dnf/apt upgrade will mean users who have it installed today, will continue to have it installed. Even if they don't use the installer:

Then on the installer side I'm asking for a similar thing. Additionally, when both the CLI and the Foreman Google plugin are enabled, it should also enabled the CLI Google plugin.

I think this PR should be merged together with the following PRs:

• https://github.com/theforeman/foreman-packaging/pull/8666 (RPM packaging)
• https://github.com/theforeman/foreman-packaging/pull/8667 (deb packaging)
• https://github.com/theforeman/foreman-installer/pull/758 installer

[stejskalleos]

@ekohl installer and deb updated, however I don't if I should be one doing the deb packaging, I don't understand it and if we want to have it in 3.5 maybe someone from packaging should take care of it.

[adamruzicka]

Foreman part works well from what I've seen, however there are some issues with hammer.

[stejskalleos]

Foreman part works well from what I've seen, however there are some issues with hammer.

See my https://github.com/stejskalleos/hammer-cli-foreman-google/pull/1#issuecomment-1302132811 in hammer plugin, for me it works well, maybe you didn't have correct branches everywhere?