Robert Müller

Results 226 comments of Robert Müller
trafficstars

I guess the token stuff specifically should be handled inside `CNetClient`, but the serverinfo specifics should not be added there.

> Where should `BrowserInfo7`(https://github.com/ddnet/ddnet/pull/8992/files#diff-64f65b9589678af8ccfe6558a3ea6712dff9e74becd3d0e22fcac74758546776R2352-R2366) function be, in CNetClient or CServerBrowser? I'd say only `SERVERBROWSE_GETINFO` and `sizeof(SERVERBROWSE_GETINFO)` belong in `CServerBrowser`. Everything else belongs in `CNetClient`, i.e. generating the token based on...

> I don't understand how to use bytes array instead of `CPacker`, `CVariableInt::Pack` has to be used for browser token. Ah, I didn't notice that. I guess it's fine to...

I tested this together with some other fixes for #9176, but it looks like the translated server info produced by this PR isn't valid in some cases yet. For example...

> program crashes on changing vsync options Did you test with the latest nightly version? #8347 should have fixed a crash when changing vsync. If you compiled with `EXCEPTION_HANDLING`, the...

Was this issue fixed by #8800 (#8635)?