drake icon indicating copy to clipboard operation
drake copied to clipboard

Improve IrisInConfigurationSpaceTest.ConvexConfigurationSpace

Open jwnimmer-tri opened this issue 1 year ago • 2 comments

We noticed in #21029 that the test case IrisInConfigurationSpaceTest.ConvexConfigurationSpace effectively doesn't check anything right now.

(We also had to add a fudge factor for macOS builds to pass CI.)

jwnimmer-tri avatar Feb 23 '24 18:02 jwnimmer-tri

I don't believe that's accurate. ConvexConfigurationSpace is a good test. In #20974, I added a small additional check to that test in an attempt to cover the new mixing_steps option, and that new aspect of the test was insufficient. But the original test is still good.

RussTedrake avatar Feb 24 '24 12:02 RussTedrake

Yes I did not intend to say that the test does nothing. I meant more specifically that ConvexConfigurationSpace does not effectively check the mixing step option

AlexandreAmice avatar Feb 24 '24 12:02 AlexandreAmice