Robin Lovelace

Results 774 comments of Robin Lovelace

I suggest we switch to using the bench package. Sound reasonable @engineerchange and @csgillespie ?

> Thoughts? Bench tells you about memory use which is important if not vital when fixing critical performance issues. I'm a fan. No need to rush it, interested to hear...

That would be quicker also than changing every instance of benchmarking. It is just a question of setting an argument so if we did switch to the `bench` in the...

Thanks @jangorecki those are good reasons for sticking with the status quo!

On a related note, I think with `dplyr` 1.0.0 and recent improvements in `data.table` it's time to refactor https://csgillespie.github.io/efficientR/data-carpentry.html. Any suggestions on that are very welcome @jangorecki !

Thanks @jangorecki, going back to the original issue, the solutions would seem to be keep the cld column or remove it in every benchmark. Which do you recommend? > The...

Thanks for the report. As author of `benchmarkme` I think @csgillespie is well-equipped to address this. Really want to update the book but it's a question of finding the time!

Good point, well spotted. A PR fixing this would be most welcome!

Sure. `remotes` didn't exist when we wrote about `devtools` (likewise `usithis`) explaining why it's not in there. I agree that it should be in there!

Interesting one, thoughts @csgillespie ?