Dan Cline

Results 124 comments of Dan Cline

After thinking about it, to remove the `Deserialize` impl we would have to remove it from a bunch of other engine API types. This might be fine, since we only...

> can we get auto issues for this? I'm not sure how to do this, but it would be amazing if we could get this somehow > did this occur...

> the question here is, why is the pipeline here active in the first place? because the CL mocker sends a FCU, and this is the first FCU, so we...

Makes sense, so #3039 should probably be followed up with distance checks, which should address #2964

Going to ignore the `Headers` stage case for now, since these hive tests now use the live sync downloaders. Now, the problem is that the full block downloaders just report...

This is still an issue, we could initialize the future with a channel that the full block future pushes to if it has capacity, otherwise it should not block on...

> Did we try this live? Want to be very sensitive to anything that touches this logic given it's in live p2p mode. Just tested this with a sepolia sync,...

> > hmm technically chainid can be u64, so this sounds reasonable, although probably a bad choice to pick a chainid where this is possible so maybe not worth it,...

> > > > hmm technically chainid can be u64, so this sounds reasonable, although probably a bad choice to pick a chainid where this is possible so maybe not...

Would note that having a chainid this close to the boundary causes problems for both saturating and wrapping, for example if the resulting `v` were 27/28 in wrapping. In saturating...