Dan Cline

Results 124 comments of Dan Cline

this was completed in https://github.com/paradigmxyz/reth/pull/16098 and https://github.com/paradigmxyz/reth/pull/16400

Just noting that to do this correctly, we also need to bring back the `Encodable` / `Decodable` implementations from before reth switched to alloy types, otherwise this would break RLP...

these traits might be more relevant for typed transaction: https://github.com/alloy-rs/alloy/blob/91941b93b8033111cf45b8f5dd1b1314d9dccce5/crates/consensus/src/transaction/rlp.rs#L10-L114 https://github.com/alloy-rs/alloy/blob/91941b93b8033111cf45b8f5dd1b1314d9dccce5/crates/consensus/src/transaction/rlp.rs#L116-L227

Note: electra at genesis also does not seem to work with lighthouse or prysm, so this may not be a teku-specific issue. Lighthouse crashes with a ssz error, prysm does...

> Will take a look into adding this over the next couple days. I _think_ should be simple enough: > > 1. Adding another flag. > > 2. Copying the...

> Is anyone on this? Could I take a stab at it? assigned! let me know if you have any questions or need review

> hey @Rjected, I'm so excited to see this PR being closed due to their complexity. I want to learn about how works the handling of queries over in-memory state....

> Well, I did my homework. I thought and reach out in this solution: > > 1. Iterates over all in-memory blocks > > 2. Search in transactions by ID...

> Makes sense. Btw, why in-memory blocks don't works equal db blocks? wdym? do you mean why do we not keep a txid index for in-memory blocks?

> > > Makes sense. Btw, why in-memory blocks don't works equal db blocks? > > > > > > wdym? do you mean why do we not keep a...