Dan Cline

Results 125 comments of Dan Cline

> This happened to me again today, dropping the stage again helped. > > Do you want me to post any more info? Hi! Do you mind sending the output...

> I'm impatient and decided I try something, I came up with adding a `panic!` to [the code where the "Failed to insert block"](https://github.com/winksaville/reth/blob/cd1c2bf99dc3ac4e02c3a027dd0e6d3da252de87/crates/interfaces/src/blockchain_tree/error.rs#L156-L168) gets printed and set `RUST_BACKTRACE=1` environment...

woah yeah exactly like this, `test-fuzz` support is super interesting too! I'll take a look and will probably do something similar

So we could use `GethInstance` from ethers, but that currently uses `--dev` which disables p2p. That part would need to be configurable. We would also need to create a `genesis.json`...

Admin namespace and some of the required `GethInstance` modifications are in [ethers#1880](https://github.com/gakonst/ethers-rs/pull/1880)

I am mainly worried about potential DoS vectors - a malicious node could send us a list of transactions that are not associated with any known header, we should not...

We could also add some constants so we name some of the "magic numbers" used in EIP155

hmmm, when running the test `TestHeaderInsertion` individually, it passes, but when running `core` tests with the new test, it fails. removing the test I added also causes `TestHeaderInsertion` to pass,...

🚀 thank you for the reviews and followup work!