Rico Suter

Results 656 comments of Rico Suter

Yeah, i was also wondering because oneOf is not really supported.. lets keep this open

I currently don't have plans to work on this project and add features... I'm planning to reimplement the project as a command line tool with support for .NET Core and...

I no longer work on this extension - the whole functionality is now moved to DNT: https://github.com/RSuter/DNT#switch-to-projects

Because we use the contract resolver internally to reflect the serialized types i would expect that `[JsonObject(ItemRequired = Required.Always)]` just works... but it seems that a custom resolver is the...

I think if the contract resolver does not respect the `[JsonObject(ItemRequired = Required.Always)]` then the serialization will also ignore it and then it is wrong to manually implement this out-of-the-box...

Ok, I've checked this in some tests and it seems that you are right: The serializer and contract resolver do not match in this case: ![image](https://user-images.githubusercontent.com/2603405/51072033-a9042680-165a-11e9-8677-db9484a01921.png) So we need to...

Yes, it's really strange, in the object contract it is set as expected: ![image](https://user-images.githubusercontent.com/2603405/51072127-f2a14100-165b-11e9-9664-e185a88503ea.png) But the property does not "inherit" this: ![image](https://user-images.githubusercontent.com/2603405/51072139-1ebcc200-165c-11e9-8cee-1eb3d864f8b0.png) But I'd expect that the property uses the...

Ah shit, we have a problem, the ItemRequired is only overridden if Required is set in the attribute, e.g. `[JsonProperty("abc", Required = Required.Default)]` and not in this case `[JsonProperty("abc")]` -...