Rico Suter

Results 610 comments of Rico Suter
trafficstars

I have the same issue. It seems that the reference just removes the dialog from the DOM but does not call the JS method which could cleanup the body etc....

@tehmantra I've update the PR to latest NJS. Please review (didnt touch the options classes => up to you to rename if you want).

Any update on this? Do you need help or any changes?

Can someone clarify what the correct null handling should be? Is it the same as with OpenAPI or JSON Schema or again completely different? I'm fine adding the AsyncAPI enum,...

> It seems like the discriminator issue alone is enough to force us to implement a different SchemaType in NJsonSchema? So we would add AsyncApi2 (and later AsyncApi3) or just...

> Alternative might be to have NJsonSchema allow custom SchemaTypes somehow? problem is that njs needs specific code based on the schema anyway, no? Here for example a different inheritance...

Just FYI, my look from a schema perspective: JSON Schema/Swagger describes a tuple type as an array with fixed length and defined type per element. The item names are not...

What would be the expected output? I think you can change that with a custom type mapper or schema processor.