Rich Harris

Results 788 comments of Rich Harris

Or `url.origin === location.origin` for that matter

Oh actually, looking at the code, we don't `return` at this point if `origin` differs because we want to run `beforeNavigate` functions for cross-document navigations (e.g. to pop up the...

A dockerfile is not a repro. Please follow the instructions you saw when you opened this issue https://github.com/sveltejs/kit/blob/master/.github/ISSUE_TEMPLATE/bug_report.yml

gah, i can't reproduce the webkit test failures locally. might have to rethink some stuff

Couldn't figure out the webkit stuff so I, err... skipped the test on webkit

Yes, this is something we've been meaning to get round to

Making a note-to-self that when we do this, we can get rid of the hacky global `fetch` override during prerendering: https://github.com/sveltejs/kit/blob/05d532bbdf4cf4e857bd74e53799f671fb4cd152/packages/kit/src/core/prerender/prerender.js#L96-L147

will mark this as draft until it's ready

What's the status of this — is it still needed? Ready for review?

Did `enforce: pre` work? `vite-plugin-svelte` extracts the CSS into a separate `.css` module which Vite knows how to extract for SSR; any replacement plugin would need to jump through the...