Rich Harris

Results 788 comments of Rich Harris

I don't think Vite needs a new option, it should just accept `/foo` as a valid pathname when `base === '/foo'`, instead of inviting you to visit `/foo/foo`

Hang on a sec @benmccann — it's _not_ working as intended. Either `dev` should be `true` in both cases where a custom mode is provided, or in neither. That's a...

> I think this is expected behaviour per the [docs](https://vitejs.dev/guide/env-and-mode.html) The docs are a bit ambiguous, I think: A lot hinges on the interpretation of 'running in production'. If it...

> I'm not sure it should reflect `command` That's a valid position, but it's often very useful to know if you're in `vite dev` or `vite build` (without juggling `mode`),...

Sorry for slow reply - I _think_ (though it's been a while since I touched this project, I've been meaning to carve out some time!) that the README is out...

Hey @aesqe, thanks for raising this - sorry I haven't replied sooner, I'm a little backed up at the moment! Just wanted to say that it's on my radar and...

Yep, afraid I don't have any time to work on this for the forseeable future. I'm currently using [Terser](https://github.com/terser-js/terser), which has proven reliable. I may get back to it one...

Thanks — do you know what input code is causing that? Any chance you can reproduce it on https://butternut.now.sh ? Also, what version of Butternut do you have installed? ```bash...

Any way you can share the input code? I should be able to figure out what's causing the error from that.

Really can't thank you enough for this, and for the small reproductions — it's been incredibly helpful! I feel like we made some pretty good progress today 🍻