kit icon indicating copy to clipboard operation
kit copied to clipboard

Respect `autofocus` after a client-side navigation or enhanced form submit

Open Rich-Harris opened this issue 2 years ago • 3 comments

#6629. This makes client-side navigation/submission behave more like their native counterparts

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Rich-Harris avatar Sep 07 '22 13:09 Rich-Harris

🦋 Changeset detected

Latest commit: 58ef6deb47c74b8c979f984be91c803ebfa9cbff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 07 '22 13:09 changeset-bot[bot]

gah, i can't reproduce the webkit test failures locally. might have to rethink some stuff

Rich-Harris avatar Sep 08 '22 14:09 Rich-Harris

Couldn't figure out the webkit stuff so I, err... skipped the test on webkit

Rich-Harris avatar Sep 08 '22 22:09 Rich-Harris

The tests pass in webkit locally (and it works as expected when testing manually in Safari) so I have no idea what's going on with the CI failures, but frankly I am well past the point of caring. Reverted 3d5a235

Rich-Harris avatar Nov 10 '22 17:11 Rich-Harris