Alireza Shabani (Revisto)
Alireza Shabani (Revisto)
@behdanisohrab, could you please check the app and give comments about the new update?
Thanks for the PR, I think BPM shouldn't reset to default (120), but about this feature in general, I'm not sure if disabling the reset button in any case is...
Hi, after doing some research, I understand how it's a good idea for the reset button to be disabled and for the BPM to be set back to default (120)....
Ah, I understand it now, it would be better to implement this. I think we need a method to check drum machine's state after each toggle press and bpm change,...
Let's commit it here and rename the PR title to a more general one.
Hi Sepehr, There are some issues, Architectural Issues: - `mark_unsaved_changes()` shouldn't manage UI elements like the clear button. Use signals/observers instead to decouple the service from UI logic. **BPM Handling...
Hi @minosimo, thank you so much for implementing your rock kit samples into the drum machine
Hi Hadi, thanks for working on this great feature. I've found some issues design-wise and have some comments to add. I'm thinking about adding maybe a gear icon on the...
This would be part of a bigger feature that Drum Machine needs, which is the ability to customise each instrument's sounds. like changing the volume, adding reverb, or, as you...
Thanks for the PR, Hadi. I would love to see PyGame gone as much as you do, but there is an issue. During testing, I found that the drum machine...