drum-machine icon indicating copy to clipboard operation
drum-machine copied to clipboard

feat: random beats dialog

Open hadi7546 opened this issue 3 months ago • 3 comments

Description

Introduce a Random Beats feature that generates drum patterns by density, with optional per‑instrument overrides, a new dialog UI, and a dedicated randomization service.

https://github.com/user-attachments/assets/51246225-6f43-4884-b927-4ea1dec1afb9

Type of Change

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] Documentation update

hadi7546 avatar Sep 07 '25 08:09 hadi7546

Awesome

MirS0bhan avatar Sep 07 '25 08:09 MirS0bhan

I've changed the page-fill-number widget to AdwSpinRow.

Screenshot From 2025-09-07 13-45-14

And I've added a Magic item to the "Default Presets" section. Now, if the user clicks on Magic, the randomizer chooses a random density from 20-50% and creates a random beat. Screenshot From 2025-09-07 13-40-28

hadi7546 avatar Sep 07 '25 10:09 hadi7546

Hi Hadi, thanks for working on this great feature. I've found some issues design-wise and have some comments to add.

I'm thinking about adding maybe a gear icon on the right side of "Magic" that opens the densities dialog to show the users it's customizable. Screenshot From 2025-09-08 21-31-03

The name seems kind of odd, especially the three dots. I think something like "Geneate Random" would fit better, I'm open to new ideas though. Screenshot From 2025-09-08 21-32-12

I think the first density slider should override them all, even the ones the user changed manually. Screenshot From 2025-09-08 21-33-31

It would be better if the volume sliders were aligned and started at the same spot. Screenshot From 2025-09-08 21-35-20

image

There is an issue when the percentage changes from 9 to 10. https://github.com/user-attachments/assets/2c2a20d5-7e54-4c1a-a398-37cb5b98dfcf

Also, consider that soon we will add this feature so users can add new samples or remove the default ones. So handling them dynamically would be better.

Thanks.

Revisto avatar Sep 08 '25 19:09 Revisto