drum-machine icon indicating copy to clipboard operation
drum-machine copied to clipboard
verified publisher icon Revisto

Implement Rock Kit samples

Open minosimo opened this issue 4 months ago • 3 comments

Description

Replaced samples with more typical Rock Kit sound

Samples are from https://ivyaudio.com/freebies

(I am the creator of Ivy Audio, and give permission to use these samples. Will switch Scott Drums to gplv3 license soon)

Relates to #14

Type of Change

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] Documentation update

Additional Notes

Let me know what you think of the sound. I'll want to adjust the editing and processing.

minosimo avatar Aug 11 '25 21:08 minosimo

Thanks a lot for your contribution @minosimo. This looks good to me, but I'll request a review from @Revisto too, as he might have some other thoughts about this.

sepehr-rs avatar Aug 12 '25 02:08 sepehr-rs

Note that the about dialog has a mention of where the drumkit is from so update that one.

vanillajonathan avatar Aug 12 '25 23:08 vanillajonathan

Hi @minosimo, thank you so much for implementing your rock kit samples into the drum machine <3

I'm going to keep this PR open till we make a sample kit switcher or something, so we can have multiple kits, such as the current one and the Rock kit you added. Thanks.

Revisto avatar Aug 14 '25 15:08 Revisto