Piotrek Koszuliński comments

Results 86 comments of


Piotrek Koszuliński

Allow custom size unit and custom option labels in FontSizeConfig

First of all, I totally forgot that you can pass such complex values to `options` as you shown @mlewand. I think no one knows that because https://ckeditor.com/docs/ckeditor5/latest/api/module_font_fontsize-FontSizeConfig.html#member-options makes it very...

Allow custom size unit and custom option labels in FontSizeConfig

> Did I miss something? :D Yeah, I missed something – how the proposed formats will look next to `FontSizeOption`... So, alternatively we could extend `FontSizeOption` like this: ```js fontSize:...

Allow passing a logger to commands

https://github.com/cksource/mgit2/pull/35#issuecomment-274782553 more here.

mgit should use `package.json` if `mgit.json` was not found

It makes sense as a feature. `mgit.json` could be optional, overriding options set in `package.json`.

mgit should use `package.json` if `mgit.json` was not found

I wanted to implement this while working on https://github.com/cksource/mgit2/issues/30 but, as you both noticed, it's more work to filter correct stuff from `package.json`.

mgit should use `package.json` if `mgit.json` was not found

You can make a PR for this. It makes sense to log such an error clearly :)