Piotrek Koszuliński

Results 86 comments of Piotrek Koszuliński

The easiest workaround I can see is doing the "add target to external links" completely manually either during the conversion (downcast) or outside the editor.

@airstarh, could you report a new ticket for this? This sounds like a separate bug.

It seems that we missed this use case somehow, or something changed in the API which makes solving this easily harder now. What I'd do now is implementing an adapter...

Is this bug reproducible on ckeditor/ckeditor5#11456?

@jimf The actual branch in this PR is production-ready **except** support for Android. Android is in ckeditor/ckeditor5#12446 and it's pretty much ready too. We're completing tests and polishing last significant...

This makes sense. With one exception: Where we import some dev utils this way. TODOs: * Check whether tree-shaking would remove such dev utils from a package if they are...

BTW, inline images in GitHub Writer makes nearly zero sense. I'll report an issue about this too because I think that at least for now, before we'll polish the UX...

I ran into this again when trying to force an integration with Strapi's media library to insert images as block images. Since it relies on toView() -> toModel() -> insertContent(),...

👆 For the ref: https://github.com/ckeditor/strapi-plugin-ckeditor/pull/14

One thing that we found while pre-reviewing the PoC in #12446 is what are those changes: [https://github.com/ckeditor/ckeditor5/pull/12446/files#diff-8e0d7c69269756056f12fa2ffff70ee41cd4037b6725fd1e4af279c84ac8686dR41](https://github.com/ckeditor/ckeditor5/pull/12446/files#diff-8e0d7c69269756056f12fa2ffff70ee41cd4037b6725fd1e4af279c84ac8686dR41) They seem to be only partially related to Android, but were added in...