Piotrek Koszuliński

Results 86 comments of Piotrek Koszuliński

It's so sad. In other words – there's no viable solution at the moment. Not only we'd have to rewrite the dropdowns but also toolbars to use exactly the same...

Let's try to approach this in 3 stages: 1. Research events fired by Android keyboards. See: [https://www.notion.so/Typing-events-scenarios-8d750fcdc8984e4fa5126e78b98e4047.](https://www.notion.so/Typing-events-scenarios-8d750fcdc8984e4fa5126e78b98e4047.) * The goal is to compile a event model common across all major...

> Pressing enter key does not trigger proper `beforeinput` event on some devices, instead it triggers `insertCompositionText` with data: `test\n` > > 1. I wasn't able to reproduce it so...

@ckeditor/qa-team I think it's worth retesting the whole thing on Android. The branch to test is [ck/11438-beforeinput-ime-research-vol1.1-android](https://github.com/ckeditor/ckeditor5/compare/ck/epic/11438-migrate-to-beforeinput...ck/11438-beforeinput-ime-research-vol1.1-android). Keyboards to cover: * Default * GBoard * Swift Languages: * English *...

Remaining issues to cover now: * Merge latest `master` to this branch. * Let's try to fix [https://github.com/ckeditor/ckeditor5/issues/12058#issuecomment-1221984375](https://github.com/ckeditor/ckeditor5/issues/12058#issuecomment-1221984375) + ckeditor/ckeditor5#12368 assuming they are the same problem. Let's simply add support...

The inner link (``) is outputted by GHS. The outer one by the automatic decorator. Those two aren't merged together because there's a conflict - both use the `rel` attribute....

Related issue: ckeditor/ckeditor5#6436.

The problem is that the logic to treat these attributes granularly would need to change in several places. A bit like the history with `StylesProcessor` that is now widely used...

The issue comes from the conflict between `addTargetToExternalLinks` which sets `rel="noopener noreferrer"` and the other manual option which sets `rel="nofollow"`. The treats `rel` as a string, not an array of...