Joel D Souza

icon indicating a website link https://joeldsouza.me

icon company @kapture-cx icon location Bengaluru, India icon location Building awesome applications for humans and businesses. A UI fanatic.

Results 4 comments of Joel D Souza

DevTools: Improve browser extension iframe support

@bvaughn By adding the below code, doesn't enable react to inspect inside an iframe. I tried the [regression test](https://github.com/facebook/react/blob/d897c35ecfb7471b55e41933fd4d993b98dbf600/fixtures/devtools/regression/server.js), didn't work there either. ```javascript __REACT_DEVTOOLS_GLOBAL_HOOK__ = parent.__REACT_DEVTOOLS_GLOBAL_HOOK__; ``` I was...

iframe unmount callback

Can I take this? All I need to do is add a new prop `contentWillUnMount` and pass it to `Content` and call it on componentWillUnmount of Content component right?

iframe unmount callback

Can you help through the steps to set up the project and run it?

Added contentWillUnmount prop to call before the Contents unmounts.

@paztis Anything else I need to change? Is there something that is blocking from merging?