react-frame-component icon indicating copy to clipboard operation
react-frame-component copied to clipboard

Published 20 hours ago • verified publisher icon ryanseddon

iframe unmount callback

Open paztis opened this issue 4 years ago • 6 comments

I know that this component is really old but it is really correctly working There's just one missing feature: be able to provide a unmount callback to be able to remove few listeners in parent app.

Is it possible to add it ?

thanks

paztis avatar Dec 10 '20 13:12 paztis

I know that this component is really old but it is really correctly working

Being old isn't such a bad thing 😄

What's your use case, do you have a codesandbox or similar I could look at?

ryanseddon avatar Dec 22 '20 04:12 ryanseddon

Good PR opportunity here if you want to contribute

ryanseddon avatar Apr 20 '21 06:04 ryanseddon

Can I take this?

All I need to do is add a new prop contentWillUnMount and pass it to Content and call it on componentWillUnmount of Content component right?

Reflex-Gravity avatar Apr 30 '21 05:04 Reflex-Gravity

yes please! just make sure you add tests and documentation to cover the new stuff

ryanseddon avatar Apr 30 '21 05:04 ryanseddon

Can you help through the steps to set up the project and run it?

Reflex-Gravity avatar Apr 30 '21 05:04 Reflex-Gravity

Good prompt for me to add a contributing.md file!

  1. Pull down the repo
  2. Run npm install
  3. Run npm run serve
  4. Open http://localhost:8080
  5. Now any changes you make to the library or example files will rebuild and refresh the browser
  6. Tests are run by npm t

ryanseddon avatar Apr 30 '21 06:04 ryanseddon