ReenigneArcher
ReenigneArcher
> Fixed the clang-format issue, and rebased again. Thanks! Looks like you mistakenly changed the build-deps submodule.
I guess something changed in the API in the new version. Our tests pass in CI, but we cannot test videotoolbox in CI. https://github.com/LizardByte/Sunshine/actions/runs/15572866499/job/43852208738?pr=3963 ``` [----------] 2 tests from EncoderVariants/EncoderTest...
Sorry, I misunderstood
The include was fixed upstream (https://github.com/miniupnp/miniupnp/commit/e263ab6f56c382e10fed31347ec68095d691a0e8), but not yet released. For the homebrew build this shouldn't be a problem anymore as I fixed it here: https://github.com/LizardByte/Sunshine/pull/3952 The other change seems...
- Can you add `avahi` here? https://github.com/LizardByte/Sunshine/blob/a940cdb394055139ca6a964289f414da562452e3/packaging/sunshine.rb#L39-L57 - > I have added or updated the in code docstring/documentation-blocks for new or existing methods/components Why did you mark it n/a? Anything...
Thank you for the updates and the explanation!
Last question, do you have any ideas on how to unit test this?
This unit test failures are not related to this PR. I need to investigate what's going on.
To see if it makes a difference, please disable display automation settings: https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2configuration.html Restart sunshine after making any config changes.
There's not a whole lot in the changelog since the latest stable. I'll try to narrow it down, but I guess it's likely from a `build-deps` update (i.e. FFmpeg). ```...