ReenigneArcher

Results 715 comments of ReenigneArcher

> "New in version 3.20." Currently, we're specifying 3.18 as the minimum required. `cmake_minimum_required(VERSION 3.18)` I'm not sure if it's possible to dynamically set the minimum version, based on the...

They aren't comfortable contributing with the CLA in place. I'm looking into adjusting it, but it will probably take some time.

If we're going to adjust the logging format, can we improve the readability a little more? I'm not an expert on boost logging, but can we do something like this?...

I agree with your points, I was just thinking it would allow us to not have to search and we could go directly the point in the code... I guess...

@vgmoose probably. I don't think the ScreenCaptureKit existed when this was first introduced into Sunshine. We would gladly accept a PR for this.

I'm getting a new error as of yesterday. ``` D:/a/_temp/msys64/ucrt64/include/winrt/Windows.Foundation.h: In member function 'winrt::Windows::Foundation::IAsyncAction winrt::deferrable_event_args::wait_for_deferrals()': D:/a/_temp/msys64/ucrt64/include/winrt/Windows.Foundation.h:3313:43: error: non-template type 'coroutine_handle' used as a template [-Wtemplate-body] 3313 | co_await awaitable{ {},...

> Clicking that notification pairs the client or opens some dialog to pair the client. It is supposed to open the web ui. Does the open sunshine option work from...

No idea, they're almost the same exact code. https://github.com/LizardByte/Sunshine/blob/64544e7960f5141f71438d72e5dedad81c03729c/src/entry_handler.cpp#L29-L37 It's called from: https://github.com/LizardByte/Sunshine/blob/64544e7960f5141f71438d72e5dedad81c03729c/src/system_tray.cpp#L308-L310

If you are still facing this issue please test the build here: https://github.com/LizardByte/Sunshine/actions/runs/14744857138?pr=3818#artifacts and report back whether it solves the issue or not? It is from https://github.com/LizardByte/Sunshine/pull/3818 which refactors how...

@daattali did you mean to re-open this? Seems like it's clearly not meant for this repo.