Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

feat(win/nvenc): add split frame encoding option

Open ns6089 opened this issue 1 year ago • 7 comments

Description

Support split frame encoding

  • Depends on #3040

Screenshot

2024-08-22 14_53_32-Window

Issues Fixed or Closed

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Dependency update (updates to dependencies)
  • [ ] Documentation update (changes to documentation)
  • [ ] Repository update (changes to repository files, e.g. .github/...)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ns6089 avatar Aug 22 '24 10:08 ns6089

The code in this pull request is Not a Contribution under LizardByte Individual Contributor License Agreement. The code in this pull request is shared under GNU GENERAL PUBLIC LICENSE Version 3.

ns6089 avatar Aug 25 '24 03:08 ns6089

Hi @ns6089 I see your tickets are closed and merged, is there a reason?

Are you not going to contribute to sunshine anymore?

moi952 avatar Aug 26 '24 12:08 moi952

They aren't comfortable contributing with the CLA in place. I'm looking into adjusting it, but it will probably take some time.

ReenigneArcher avatar Aug 26 '24 12:08 ReenigneArcher

They aren't comfortable contributing with the CLA in place. I'm looking into adjusting it, but it will probably take some time.

Without indiscretion, what part of the CLA is it on?

So the development he has already done on the 444 will be rolled back?

It's really too bad because the split frame encoding seems interesting.

I'm keeping my fingers crossed that you can find an agreement.

moi952 avatar Aug 26 '24 13:08 moi952

@ReenigneArcher I can speak for myself, thank you. @moi952 I don't have a problem with anything already merged, don't worry.

ns6089 avatar Aug 26 '24 16:08 ns6089

Reopening now that the CLA has been revoked and this can now be accepted under the GPLv3 terms alone.

cgutman avatar Aug 28 '24 02:08 cgutman

Quality Gate Failed Quality Gate failed

Failed conditions
127 New issues
124 New Code Smells (required ≤ 0)
3 New Bugs (required ≤ 0)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Aug 28 '24 02:08 sonarqubecloud[bot]

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

LizardByte-bot avatar Jan 18 '25 10:01 LizardByte-bot

This PR was closed because it has been stalled for 10 days with no activity.

LizardByte-bot avatar Jan 28 '25 10:01 LizardByte-bot