Sunshine fix(win/cmake): file(TO_NATIVE_PATH) broke in latest cmake

Description

file(TO_NATIVE_PATH) broke in latest cmake.

At least in the scoop version of cmake-3.30.3 slashes don't get reversed. cmake_path(CONVERT TO_NATIVE_PATH_LIST) works fine and this seems to be the intended way to do it anyway. "New in version 3.20."

Screenshot

Capture

Issues Fixed or Closed

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency update (updates to dependencies)
[ ] Documentation update (changes to documentation)
[ ] Repository update (changes to repository files, e.g. .github/...)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Sep 06 '24 13:09 ns6089

"New in version 3.20."

Currently, we're specifying 3.18 as the minimum required.

cmake_minimum_required(VERSION 3.18)

I'm not sure if it's possible to dynamically set the minimum version, based on the OS or whatever. I'm fine with bumping it though. All our linux builds will compile cmake if it's lower 3.25 right now anyway. Could possibly cause issues for anyone self compiling on older LTS releases.

Sep 06 '24 20:09 ReenigneArcher

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.82%. Comparing base (fb712e3) to head (126c775). Report is 91 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #3152   +/-   ##
======================================
  Coverage    9.82%   9.82%           
======================================
  Files         101     101           
  Lines       17981   17981           
  Branches     8419    8419           
======================================
  Hits         1767    1767           
  Misses      13323   13323           
  Partials     2891    2891