Reto

Results 185 comments of Reto

LGTM, I can approve once https://github.com/knative/serving/actions/runs/8965592118/job/24619389624?pr=15180 passes.

@dsimansk mind approving the above? @dprotaso is on PTO and the pkg/apis change is only a (now invalid) comment.

If I understand the discussion in https://github.com/knative/serving/issues/13812 correctly I think this is fine. Dave is now on PTO, as he has done the recent larger rework in that area, let's...

Hm it is the container that serves the traffic, so I'm also throwing `TrafficContainer` in here :) Opinions? @dprotaso @rhuss

> This extra hop through the local-gateway is unnecessary and causes problems with authorization policies that have different rules for local vs ingress gateways. It is not really unnecessary. DomainMapping...

Hm something is definitely off with your setup: `webhook.serving.knative.dev` should point to the pod `webhook` in `knative-serving` namespace. The response looks like you get it from `net-istio-webhook` which is the...

See also discussion in https://github.com/knative/serving/pull/14853#discussion_r1479453847