serving icon indicating copy to clipboard operation
serving copied to clipboard

Published 20 hours ago • verified publisher icon knative

Rename `UserContainer` to `ServingContainer`

Open ReToCode opened this issue 11 months ago • 15 comments

Description

We currently name the "main" container of a KnativeService UserContainer. As all containers, including sidecars, are provided by the user this name is not ideal. We should check if it is feasible to rename it to ServingContainer without breaking our API.

Todo

  • [ ] Check if UserContainer can be renamed without breaking the API
  • [ ] If possible, rename all occurrences in pkg
  • [ ] If possible, rename all occurrences in serving
  • [ ] If possible, rename all occurrences in docs

ReToCode avatar Mar 13 '24 07:03 ReToCode

ServingContainer sounds like that the container belongs to Serving somehow though. I would prefer something like "AppContainer", "MainContainer", "PrimaryContainer" wdyth?

skonto avatar Mar 13 '24 09:03 skonto

Hm it is the container that serves the traffic, so I'm also throwing TrafficContainer in here :) Opinions?

@dprotaso @rhuss

ReToCode avatar Mar 13 '24 10:03 ReToCode

+1 one for what @skonto says; the name should reflect its key characteristics. TrafficContainer depicts it, but without context, it sounds weird and confusing, IMO. I like MainContainer because that's what it is, the MainContainer, all others are sidecar containers. Another option, which kind of is in-between, could be TargetContainer, but I think MainContainer is clear and simple and is an established 'concept'.

rhuss avatar Mar 13 '24 13:03 rhuss

Hey @ReToCode, @rhuss, and @skonto, I want to work on this issue.

prashantrewar avatar Mar 16 '24 04:03 prashantrewar

/assign

NightFury742 avatar May 25 '24 21:05 NightFury742

/assign

asr2003 avatar May 28 '24 18:05 asr2003

/unassign @asr2003

the issue is already assigned to @NightFury742

dprotaso avatar May 28 '24 22:05 dprotaso

if @NightFury742 is not working on this issue, can I work on this?

EraKin575 avatar Jun 17 '24 11:06 EraKin575

@NightFury742 can you comment if you're still working on this issue?

dprotaso avatar Jun 25 '24 13:06 dprotaso

@dprotaso I am not working on it. @EraKin575 could take this one

NightFury742 avatar Jun 26 '24 23:06 NightFury742

/unassign @NightFury742 /assign @EraKin575

dprotaso avatar Jun 27 '24 18:06 dprotaso

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 26 '24 01:09 github-actions[bot]

/remove-lifecycle stale

ReToCode avatar Sep 26 '24 07:09 ReToCode