Jake Verbaten

Results 307 comments of Jake Verbaten

I think this is needed, but we should keep an eye on it. Can we add a custom logline here so we can see how often this happens. This should...

I think there is a lot of test code that assumes when ad() finishes then all the connections are open. We could just only denounce in ring change. I.e. Edge...

Even if we had per process circuits we still need to avoid triggering the per endpoint circuit. We need per caller and per endpoint circuits.

See https://github.com/uber/tchannel/pull/1286

@jwolski Looks like we've downgraded this from a fatal thrown exception into a logger.error(). Not quite sure what the cause is but that log should have a lot of context....

@jwolski pretty sure I have a pr for this. https://github.com/uber/tchannel-node/pull/164

I recently choose to try server-side bundling for some projects. I would recommend `parcel` ```bash parcel build index.js --bundle-node-modules --target node --no-minify --log-level 4 ``` This does a great job...

I just tried `parcel` with `bufrw` and it generates a working bundle ; i'd second that this is an issue with `babel` and `webpack` ;

Have you tried opening a bug report on the `jest` project ?

Yeah it's the missing `"main"` field which causes an error on `sql-template-tag` package which appears to be ESM only and only has an `exports` set in the package.json