hyperbahn icon indicating copy to clipboard operation
hyperbahn copied to clipboard

Circuit breaker too aggressive during service restart

Open Raynos opened this issue 9 years ago • 2 comments

If a service gets redeployed, it will stop and start a bunch of workers.

For each worker that's restarted it will ECONNRESET the socket and kill some inflight RPCs.

The circuit breaker immediately kicks in and things there is something wrong with the service.

We should ensure that we can do a rolling restart of all instances of a service without the circuit breaker penalizing all the caller.

cc: @kriskowal @jcorbin @rf

Raynos avatar Dec 07 '15 19:12 Raynos

Wouldn't per-process circuits get around this? I think we had thrown that idea around before.

blampe avatar Dec 07 '15 19:12 blampe

Even if we had per process circuits we still need to avoid triggering the per endpoint circuit.

We need per caller and per endpoint circuits.

Raynos avatar Dec 07 '15 20:12 Raynos