Jake Verbaten comments

Results 307 comments of


                                            Jake Verbaten

trafficstars

Using `path` to fully support windows

[path](https://github.com/substack/node-browserify/blob/master/builtins/path.js) has already been forked for the client by SubStack

Implement cardinality check.

@markyen I addressed feedback.

Global search in regex

I understand what you mean, you would want to to have all the global captures starting from index 0. This seems fine. However that is a backwards compat change from...

Allowing Multiple Routes with same path

I don't want to change the public interface of this module.

alias addRoute to add

Neutral. I'd rather keep the interface stable.

Allowing Multiple Routes with same path

@glassresistor If you want to make a PR to update the documentation with known caveats and a link to your implementation that works around it then :+1: will merge :)

Adding routes with the same path causes problems

I'm not going to change the internals. I recommend you do ``` js router.addRoute('samePath', function () { // some magic. function1(); // some more custom magic. function2(); }); ```

Adding routes with the same path causes problems

Cool, nice work.

Adding routes with the same path causes problems

Released v2.0.0 If you define path twice it now throws an exception.

Adding routes with the same path causes problems

At this point, this module is no longer maintained. I use: - https://github.com/Matt-Esch/http-hash and @glassresistor maintains - https://github.com/glassresistor/i40 I should update the README.