Pedro J. Estébanez comments

Results 86 comments of


                                            Pedro J. Estébanez

Make `push_error` and `push_warning` print name of calling function

Precisely these days I'm trying to hunt down the root trigger of certain operations and the ability to obtain a proper C++ stack trace would come super handy. Regarding the...

Make `push_error` and `push_warning` print name of calling function

> @RandomShaper Yes, just looking at the MacOS implementation, there is definitely a lot of overlap in functionality that could be moved into a separate library to save some duplication....

Incorrect compilation of shaders in Forward Mobile causes it + D3D12 crash Godot

@matheusmdx's and @Noiros' crashes are due to D3D12 not being able to initialize. The way the situation is reported is cryptic indeed. We need to improve that. You may get...

Incorrect compilation of shaders in Forward Mobile causes it + D3D12 crash Godot

Regarding the shader compilation crash itself, I've been able to reproduce it and I'm working on a fix.

Incorrect compilation of shaders in Forward Mobile causes it + D3D12 crash Godot

The mobile shader turned out to trigger the usage of a SPIR-V opcode that was left as a _to do_ in the patch for SPIR-V-to-DXIL dependency. https://github.com/godotengine/godot-nir-static/pull/14 should do the...

Fix call with wrong arguments in Callable.callv() when passing a readonly (const) Array

A few thoughts: - CoW involves dealing with the atomic refcount, with performance implications. - This looks like an _ad hoc_ fix for an issue due to how read-only arrays...