Warren Frame

Results 118 comments of Warren Frame

Hiyo! A few quick thoughts! * I'd suggest mapping volumes for both data and logs as @lostInSpaceSomewhere alluded * At least mention that 7473 for https, maybe publish it if...

Hiii! Awesome idea! Sorry for the delay, and for the quantity of feedback!

Hiyo! Thanks, and sorry for the... year of waiting? ouch! Some quick questions: * Could there be scenarios where both HadErrors is $false, and $Module is not defined? Would it...

Sure, I'm guessing there are a good number of folks out there who end up doing this rather than getting a Nuget repo up and running. If you're still interested...

gotcha - It might be worth looking for CI_PIPELINE_IID, and falling back to CI_PIPELINE_ID for compatibility (IID is per project, ID increments globally for all projects, so could be painful...

Hi! Haven't caught up on this thread, but I _think_ `$Path` might need to be adjusted? Invoke-Git actually [sets the processes working directory to this](https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Invoke-Git.ps1#L95), so git log should be...

Agreed, consistency would be good. Will get back to you but might be a bit (other priorities on this and other projects, summit proposal pestering, wrapping up work before parental...

Alrighty! Apart some whitespace / formatting oddities and a few comment based help things that aren't accurate (but are very unlikely to be used - can still bump version just...

Ahh good catch! I'll look at updating the embedded module to the latest, and poking around to see if the code in that spot is still not working Cheers!

Oh! Very good point, completely agree. Might make it fall back: * Nuget version exists? Use it. Otherwise... * Manifest? Use that version. Otherwise... * No manifest (odd scenario)? Use...