Benjamin Saunders

Results 609 comments of Benjamin Saunders

This doesn't seem to happen anymore; pull request 14 includes a restoration of the dispose call.

The use case, and desired semantics, are exactly that of the std [`HashMap::entry`](https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.entry) API (see also `BTreeMap`, etc). `put_if_missing` isn't a solution because my use of `LruCache` is to avoid...

> I don't think hashbrown is a good fit It'd be nice to benefit from hashbrown's optimizations. It seems like the only missing piece here is the ability for the...

On review, I think this could be accomplished with the existing interface by constructing the LRU list from bucket indices rather than raw pointers. As a bonus, I think this...

@jeromefroe, would you be interested in a PR to replace the use of pointers with bucket indices, and thereby remove all the boxing?

Hmm, bucket indexes still need to be rewritten on rehash. This would be really easy if hashbrown exposed a hook to rewrite entries on rehash, and otherwise seems infeasible.

A pure llvm-config approach has been implemented for Windows support in 1f9574dc1538a9c362e885bd104ae30f8150ff74, and appears to function adequately. In light of that, I think we should revisit the decision to use...

The high level bindings here aren't entirely appropriate for dynamic code generation such as demonstrated in the official LLVM tutorials. See [my pull request](https://github.com/bos/llvm/pull/39) for a direct interface to the...

The C API wrapper is now available in the current release, along with a more haskelly interface that still follows the C API's contours in LLVM.ST.

This is a deliberate feature of the upstream LLVM API, intended to ensure that API users don't need to worry about name mangling. I'm not convinced that it's appropriate to...