Benjamin Saunders
Benjamin Saunders
If external crates are to composably define shapes that need to dispatch recursively (i.e. compound shapes similar to HeightField), then I don't see any alternatives to the original proposal. However,...
> My keyboard has over 140 keys and sends out quite a variety of these, and I really exceptionally hate that so many programs don't support them. It's worth noting...
Including these seems reasonable to me. More narrowly, the `mimes: HashSet` argument feels like a strange choice of type, particularly as the setter immediately proceeds to convert it into a...
> `WindowEvent::KeyPress(Some(LogicalKey::A), _, flags) if flags.is_down() => ()` Some alternative conceptions, since if we're going to break things we should not consider the status quo to be the only alternative...
In lieu of `#[non_exhaustive]` (which we may want to avoid for MSRV reasons per discussion in #1355), struct variants do not have *genuine* forwards-compatibility, because exhaustive matches can be written,...
Overall those examples look good to me: forwards-compatible without unduly compromising ergonomics.
Food for thought: an enum could be compared (but not matched) against concisely and without imports by writing `as u8`.
I rather liked the maximal concision of `== 0`, but it's hard to argue with the readability of named constants/predicates, especially since my guess for which integer represented "middle" was...
I'm a big fan of `tracing` due to how easy it makes it to establish context for log messages. Helps reduce scrolling around in a big dump trying to correlate...
Yeah, though if the loader keeps searching when dlopen returns an error it should Just Work.