Ingvar Stepanyan
Ingvar Stepanyan
They're not really `Identifier` because `Pattern` is further extended in es2015+.
@nzakas I agree these things should be standardized, and not necessarily related to CST (@mikesherov) but rather just to definition of what we consider part of node and what not....
I wonder if it would be possible instead to define this as a boolean field in contexts where it matters in runtime (like Identifier in example above). Then it would...
@mikesherov I'm fine with it. But I believe the most important is to get agreement from @dherman or others people who worked on SpiderMonkey AST in the first place, as...
Hmm. In general, this seems reasonable - we do have `shorthand` on `Property`, so why not here.
> would always need a fallback check to see if the local and imported nodes are the same It's not the same though? Such fallback doesn't convey information about whether...
@mikesherov Last time couldn't think of a good wording to specify that, I can give it another try.
I think it's still useful and valuable, but there was some confusion above as to whether ESTree should represent nodes that wouldn't pass early errors checks.
Acorn also produces `raw` property, but I'm not sure if it's something that should be standardized as a "must" for all the parsers as raw representation can be easily retrieved...
@ariya Makes sense, thanks for a good example.