Ingvar Stepanyan
Ingvar Stepanyan
> this change saves me hundreds of loop, object manipulation, and conditional checks Did you benchmark it? That's the only way to prove that change is actually worth it, it's...
> In my case you can increase this performance gain by 100x if you zoom out to my application How so? Proportions shouldn't change from either number of times you...
> On par with the for loop: esbench.com/bench/5ce6e64a4cd7e6009ef62526 Looks like your link doesn't have reduce version, could you recheck/update please?
Thanks! As expected, particular results differ between browsers - this one is from Firefox - but at least it's indeed better perf-wise than for-in version: 
cc @kripken @aheejin
> Overall I would rather optimize for lowering their compile time, not on performance or features at the expense of compile time. That sounds odd tbh. Compile times are affecting...
> This allows `Serializer::serialize_maps_as_objects` to actually be used. It can already be used via [`value.serialize(...)`](https://docs.rs/serde/latest/serde/trait.Serialize.html#tymethod.serialize).
Hm. It's the standard Serde method, it seemed unnecessary to also document it in just another one of Serde's implementations.
Adding a doc comment makes sense. Let's add it in a separate PR though, it's a lot easier to review bite-sized changes :)
Yeah unfortunately that wouldn't be possible.