Rocco Meli

Results 226 comments of Rocco Meli

Given that it is more text than code, is it worth thinking about a CC license as well?

I was thinking more about a dual license model that I've seen multiple times in this scenario: CC for text and GPL for code? CC-BY-SA is reasonably aligned with GPL...

@IAlibay is this still relevant? 2.7.0 deployed successfully and in https://github.com/MDAnalysis/UserGuide/issues/350#issuecomment-1902077676 you mentioned you fixed all the outstanding issues, but I don't see anything linked here. Am I missing something?

Ok, sounds good! Thanks for the clarification and for the other fixes!

@lilyminium is this PR still relevant?

@jandom Thanks for looking at old issues. I also added a "close?" label as in the main repo in case you need it (but inactive is good too).

@mhmohona sure, you are welcome to work on the issue. However, there is some discussion that needs to happen. > we need to work out how best to handle this...

> The reproducibility of the values is a little more concerning, one should be able to write a test just in the IRC library that confirms there is a problem....

@AlexB67 I added a small test for consecutive forward and backward transformations (this is where the error appears if I understand correctly?) as follows: ```cpp const vec irc_0 = cartesian_to_irc(x_c,...

@AlexB67 Thanks for the additional details, are the test available somewhere? If you could open a PR against the `issue-52` branch it would be great, so that the problems will...