Rory Mitchell
Rory Mitchell
https://github.com/NVIDIA/cccl/issues/6595 is preventing us from making this constexpr. We can defer implementing constexpr or I will use another algorithm to generate the normal distribution.
I am a bit unsure about the naming yet and if we would support variants of this engine. I'm thinking as follows: pcg64_engine - PCG XSL RR 128/64 algorithm templated...
@davebayer @fbusato please re-review thanks :)
@miscco test_engine has the constexpr evaluations inside it. Its already testing constexpr for c++20 - if I understand you correctly.
/ok to test 2cdb853a928a43f3e7b622918c85bfcfc41119c2
Will merge as is according to @miscco `s comment.
Can you achieve this with a custom callback?
Thanks for your contribution! Here is a version of your script that does not change DMatrix. Please check it and tell me if it's correct. I am passing row indices...