cccl icon indicating copy to clipboard operation
cccl copied to clipboard

Implement PCG64 as extension

Open RAMitchell opened this issue 2 months ago • 14 comments

Description

Part of #5679

Depends on #6109

RAMitchell avatar Oct 20 '25 14:10 RAMitchell

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Oct 20 '25 14:10 copy-pr-bot[bot]

I am a bit unsure about the naming yet and if we would support variants of this engine.

I'm thinking as follows:

pcg64_engine - PCG XSL RR 128/64 algorithm templated on the multiplier/increment pcg64 - named instance of the above engine with default multiplier/increment pcg64_discard - a version of pcg64 that can discard a compile time or runtime number of values with each operator(), allowing higher performing "leapfrogging" PRNG in GPU kernels.

@fbusato maybe you have some thoughts?

RAMitchell avatar Oct 28 '25 11:10 RAMitchell

pcg64_engine - PCG XSL RR 128/64 algorithm templated on the multiplier/increment pcg64 - named instance of the above engine with default multiplier/increment pcg64_discard - a version of pcg64 that can discard a compile time or runtime number of values with each operator(), allowing higher performing "leapfrogging" PRNG in GPU kernels.

these names are perfectly fine. I'm thinking if there are better names for pcg64_discard but I'm not sure

fbusato avatar Nov 04 '25 23:11 fbusato

/ok to test a628a81

fbusato avatar Nov 07 '25 21:11 fbusato

😬 CI Workflow Results

🟥 Finished in 1h 21m: Pass: 43%/89 | Total: 1d 06h | Max: 1h 17m | Hits: 99%/56789

See results here.

github-actions[bot] avatar Nov 07 '25 22:11 github-actions[bot]

/ok to test 78e1f4a

miscco avatar Nov 10 '25 10:11 miscco

/ok to test a289174

davebayer avatar Nov 10 '25 11:11 davebayer

😬 CI Workflow Results

🟥 Finished in 59m 04s: Pass: 91%/90 | Total: 11h 09m | Max: 32m 58s | Hits: 99%/207831

See results here.

github-actions[bot] avatar Nov 10 '25 12:11 github-actions[bot]

/ok to test 5d9cdae

miscco avatar Nov 10 '25 13:11 miscco

🥳 CI Workflow Results

🟩 Finished in 57m 26s: Pass: 100%/90 | Total: 12h 59m | Max: 36m 46s | Hits: 99%/219211

See results here.

github-actions[bot] avatar Nov 10 '25 14:11 github-actions[bot]

😬 CI Workflow Results

🟥 Finished in 1h 46m: Pass: 93%/90 | Total: 17h 06m | Max: 1h 19m | Hits: 99%/210943

See results here.

github-actions[bot] avatar Nov 12 '25 14:11 github-actions[bot]

😬 CI Workflow Results

🟥 Finished in 2h 10m: Pass: 95%/88 | Total: 1d 10h | Max: 1h 20m | Hits: 98%/211898

See results here.

github-actions[bot] avatar Nov 13 '25 11:11 github-actions[bot]

😬 CI Workflow Results

🟥 Finished in 5h 38m: Pass: 95%/88 | Total: 1d 10h | Max: 1h 20m | Hits: 98%/211898

See results here.

github-actions[bot] avatar Nov 13 '25 15:11 github-actions[bot]

🥳 CI Workflow Results

🟩 Finished in 2h 24m: Pass: 100%/88 | Total: 1d 19h | Max: 1h 37m | Hits: 95%/212945

See results here.

github-actions[bot] avatar Nov 14 '25 11:11 github-actions[bot]

@davebayer @fbusato please re-review thanks :)

RAMitchell avatar Nov 17 '25 10:11 RAMitchell

🥳 CI Workflow Results

🟩 Finished in 2h 12m: Pass: 100%/88 | Total: 1d 01h | Max: 2h 09m | Hits: 99%/212945

See results here.

github-actions[bot] avatar Nov 17 '25 14:11 github-actions[bot]

🥳 CI Workflow Results

🟩 Finished in 2h 25m: Pass: 100%/88 | Total: 14h 21m | Max: 1h 35m | Hits: 99%/212945

See results here.

github-actions[bot] avatar Nov 18 '25 10:11 github-actions[bot]