NVIDIA
Update linear_congruential_generator with constexpr, tests and a fast discard
Description
closes Part of #5679
Update linear_congruential_generator with constexpr, stream operators, tests and a fast discard operator for common parameters.
This pull request requires additional validation before any workflows can run on NVIDIA's runners.
Pull request vetters can view their responsibilities here.
Contributors can view more details about this message here.
![copy-pr-bot[bot] avatar](https://avatars.githubusercontent.com/in/354886?v=4 "Published by a pub.dev verified publisher"){kind=small}
@miscco test_engine has the constexpr evaluations inside it. Its already testing constexpr for c++20 - if I understand you correctly.
😬 CI Workflow Results
🟥 Finished in 1h 57m: Pass: 91%/90 | Total: 22h 07m | Max: 1h 40m | Hits: 94%/186274
See results here.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
😬 CI Workflow Results
🟥 Finished in 1h 09m: Pass: 98%/90 | Total: 21h 52m | Max: 1h 08m | Hits: 94%/215089
See results here.
🥳 CI Workflow Results
🟩 Finished in 1h 50m: Pass: 100%/90 | Total: 22h 13m | Max: 1h 08m | Hits: 94%/219163
See results here.
😬 CI Workflow Results
🟥 Finished in 3h 12m: Pass: 93%/90 | Total: 1d 00h | Max: 1h 20m | Hits: 94%/210897
See results here.
😬 CI Workflow Results
🟥 Finished in 2h 37m: Pass: 95%/88 | Total: 1d 13h | Max: 1h 36m | Hits: 95%/211852
See results here.
🥳 CI Workflow Results
🟩 Finished in 2h 07m: Pass: 100%/88 | Total: 22h 01m | Max: 1h 40m | Hits: 99%/212899
See results here.
approved. One last suggestion, could you please change
__Ato single underscore_Afor template parameters?
I am not in favor, single letter _A macros are frequently used by the compiler. Dont ask me why, but for example _T is used by MSVC to convert string literals