Muhammad Rizqi Nur
Muhammad Rizqi Nur
>except renameing the VAE. Yes that's the idea. Auto is there to support old behavior where WebUI automatically identify and load VAE of a checkpoint indicated by having the same...
> OK, so the bottom line of all this is, that VAE will die out in the foreseeable future ... ? Separate VAE file? I guess so. The feature will...
It's not changing other options, just refresh it. But okay, I'll go cherry pick it in another PR and remove the things you don't want.
Oh, also, thanks @Omegastick for testing :)
It's true. Model caching now requires deepcopy somehow. Tests I did in #4214 passed just fine while it still used dict.copy(). The same test now didn't pass in #4666, until...
> @R-N When you made this PR [17f9e55](https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/17f9e55667ba4144232543bf12b94e75ebd4bd6f) did you check if it was working? I did. I didn't document it though, so I wasn't sure if I did it...
> Did the alternative PR for this issue not fix this? (#4514) Yes, it solved the checkpoint loading. But I just found out that the same thing happened to VAE,...
> So that means we can further zoom in to the faulty PR? Since your this PR is in the middle of the range you stated previously. Well, yes, we...
> When you made this PR [17f9e55](https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/17f9e55667ba4144232543bf12b94e75ebd4bd6f) did you check if it was working? I just realized that I can just make a branch on my commit (bf7a699845675eefdabb9cfa40c55398976274ae) and test...
> @R-N new PR here: #4991 Wait, what. I was just apologizing about it... Anyway, if you do deepcopy with the current caching flow, you'll end up with a deepcopy...