Results 124 comments of Arthur O'Dwyer

The "can't track a property named `token`" part is a limitation of the remote API that can't be fixed client-side, but the "mutates the given object" part seems like a...

Just for the record, providing a callback would not 100% solve @workmanw's problem. In that callback, you could be assured that api.mixpanel.com had responded with 200 OK to your alias...

You'll have copy elision in both places, yes; that's been true on all mainstream compilers (GCC/Clang/EDG/MSVC/Intel) since circa 2006. I was confused because in #847 the compiler directly told you...

> I can't reproduce the warning anymore [...] with Clang 6 The diagnostic `-Wreturn-std-move` has been in Clang trunk only since February 2018; I don't think it would have been...

@marcomagdy: I can 100% confirm that `-Wreturn-std-move` has never appeared in any version of GCC as of this writing. (But people do sometimes build with multiple compilers and get confused...

Indeed, the offending code is still there at https://github.com/aws/aws-sdk-cpp/blob/9e0c8b0831e89c5b562042bf5d0315551ca201ad/aws-cpp-sdk-core/source/utils/crypto/Cipher.cpp#L112 The main issue here is that you're suppressing NRVO (a.k.a. copy elision), which degrades performance for no benefit. The secondary issue...

Confirmed, this is still a problem. https://github.com/aws/aws-sdk-cpp/blob/e009d9a/aws-cpp-sdk-core/source/utils/crypto/Cipher.cpp#L112 @marcomagdy: Please make the fix you talked about in https://github.com/aws/aws-sdk-cpp/issues/920#issuecomment-409013155 . It's been three years; you should just do it. I'm going to...

FWIW, I work on a codebase where we don't use `RdKafka::KafkaConsumer` but we do wrap librdkafka in _our own_ C++ wrapper; and we very reproducibly see a hang in our...

``` :7:8: warning: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely [-Wstack-exhausted] struct Deferred { ^ :4:9: note: in instantiation of requirement here...

Update: MSVC seems to be able to compile hyper.cpp without hitting that internal limit, which is cool. But now MSVC's linker is unhappy for a different reason. I'll look into...