Arthur O'Dwyer
Arthur O'Dwyer
@ot: Ah, I either misread the old code or had a brain fart. We're not comparing "non-trivial copy `size()` elements" against "memcpy `size()` elements"; we're comparing "trivial copy (i.e. memcpy)...
> If I understand correctly the intent of the patch, it is just to extend the optimization to relocatable but non-trivially copyable types, correct? Yes, but only in _this_ place,...
> > Yes, but only in this place, which uses relocation > > Move-assignment should benefit from this too, why not use it there as well? One _could_ do something...
...Oh, or you could do move-assignment by "destroy and relocate-into", like this: ``` if (is_trivially_copyable_v && kWholeBufferIsSmall) { copyInlineTrivial(o); o.resetSizePolicy(); } else if (isRelocatable::value) { // [X Y Z _...
Cool, 2459e172518a7b5d55292b0d8b741ff14def87ba LGTM! (At least I see nothing wrong with it in a five-minute glance.) FWIW, I like your refactor into `moveInlineStorageRelocatable` that pushes down the branch on "how much...
I noticed today that [the Bikeshed help document uses appendices](https://tabatkins.github.io/bikeshed/#infotree), but it nowhere explains how to generate them. It would be nice if Ctrl+F'ing for "Appendix" in the help doc...
FWIW, according to my commit messages, I last compiled this `wxgui` stuff in 2020, using "wxmac 3.0.4_2"; before that the last significant change was in 2017; and the last significant...
Duplicates #4556 and #4504 (but yes, @emasab or someone, please merge either one of these already, and close the other!)
> I notice you use pure shift-and-add for div. Did you investigate any other typed of long div/rem algorithms, such as Knuth's or similar? No, because I am lazy. :)...
Some more background reading: https://fgiesen.wordpress.com/2012/07/21/the-magic-ring-buffer/ And a sample implementation: https://en.wikipedia.org/w/index.php?title=Circular_buffer&oldid=600431497#Optimized_POSIX_implementation