Quentin

Results 15 comments of Quentin

I wonder if [this](https://stackoverflow.com/questions/36753548/keycode-on-android-is-always-229) and [this](https://bugs.chromium.org/p/chromium/issues/detail?id=118639) might be the root causes. Basically Android keyboard does not send `keyCode`. I also encounter that kind of issues.

I ran into the same issue, I will try to come with a PR next week.

Suggestion: Rename `closeOnWindowScroll` into `closeOnScroll` Value: boolean | css selector | HTMLelement If the value is a boolean and is equal to `true` set the selector to `document` ``` js...

ping @anthonyshort !

Would it be possible to update the `bower.json` file consequently ?

https://github.com/imagemin/imagemin/blob/master/index.js#L11 `const dest = output ? path.resolve(output, input) : null;` Not sure how this can work if `input` is already a relative path to the file ? It should be...

``` js test('should output at the specified location', async t => { const files1 = await m(['fixture.jpg'], 'output', {use: imageminJpegtran()}); const files2 = await m(['output/*.jpg'], 'output', {use: imageminJpegtran()}); t.is(path.relative(__dirname, files1[0].path),...

We might want to use https://github.com/contra/glob2base.

@kevva It works for simple patterns, but when you're using globstars (`**/*.jpg`) it does not