Quentin Bisson
Quentin Bisson
@schoen2 as stated at the top of the file you are trying to edit, this needs to be fixed upstream. Otherwise, this will be overriden the next time renovate runs
@schoen2 i think you can just run the dashboard update script in this repo now and close this PR :)
LGTM, let's wait for the CI. Thank you for the contribution
@sylvainOL hey it looks like your PR has conflicts. Do you think you could double check the port configuration and fix the conflicts so we can get this merged?
Could you upgrade the chart once last time? Thank you
I also use go on a daily basis but I would tend to not change things that work but if more people want to do that, it's fine for me...
Hey @BahmaniAlireza did you check the top of the file https://github.com/BahmaniAlireza/helm-charts/blob/592c28beacded53b817fb54ebdc7ef2bc91a8ac6/charts/kube-prometheus-stack/templates/grafana/dashboards-1.14/etcd.yaml#L4?
I think it makes sense thank you :) LGTM
It needs a review from @Jayclifford345 or @nicolevanderhoeven
No it does not because this is the line that should be changed: ``` pluginAddress := fmt.Sprintf("%s:%d", service.Name, pluginPort) ``` Which I think is line 216 in the plugin controller...