helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[kube-prometheus-stack] Fix AngularJS deprecation in grafana-overview…

Open schoen2 opened this issue 6 months ago • 2 comments

… dashboard

What this PR does / why we need it

  • Fixes Angular depreciation of Grafana-overview dashboard

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #4854

Special notes for your reviewer

  • I only changed twice the "graph" type, to "timeseries" in "RPS" and "Request Latency" panels in grafana-overview dashboard

Checklist

  • [x] DCO signed
  • [ ] Chart Version bumped
  • [x] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

schoen2 avatar Jun 10 '25 05:06 schoen2

FYI, I opened a PR in grafana-mixin als well https://github.com/grafana/grafana/pull/106462

schoen2 avatar Jun 10 '25 06:06 schoen2

@schoen2 as stated at the top of the file you are trying to edit, this needs to be fixed upstream. Otherwise, this will be overriden the next time renovate runs

QuentinBisson avatar Jun 18 '25 09:06 QuentinBisson

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] avatar Jul 18 '25 21:07 stale[bot]

@schoen2 i think you can just run the dashboard update script in this repo now and close this PR :)

QuentinBisson avatar Aug 25 '25 12:08 QuentinBisson